Skip to content

Conversation

@sis0k0
Copy link
Contributor

@sis0k0 sis0k0 commented Aug 2, 2017

When querying for ng-components (natively represented by
ProxyViewContainers), the container's children are selected instead of
the container itself.

When querying for `ng-components` (natively represented by
`ProxyViewContainer`s), the container's children are selected instead of
the container itself.
@sis0k0 sis0k0 requested a review from vakrilov August 2, 2017 10:35
@sis0k0
Copy link
Contributor Author

sis0k0 commented Aug 2, 2017

Sample application: https://github.com/NativeScript/ns-ng-routable-animations
Note: You need to install nativescript-angular from this branch.

@sis0k0 sis0k0 added this to the 4.2 milestone Aug 2, 2017
@sis0k0 sis0k0 requested a review from vchimev August 2, 2017 13:17
@vakrilov vakrilov merged commit e2e4f5a into master Aug 2, 2017
@vakrilov vakrilov deleted the vlaeva/router-animations branch August 2, 2017 13:51
@ghost ghost removed the ready for test label Aug 2, 2017
@jogboms
Copy link

jogboms commented Aug 17, 2017

@sis0k0 I experienced an Issue since I upgraded to 4.2. I wrote about it here #941

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants